cloud-fan commented on a change in pull request #32816:
URL: https://github.com/apache/spark/pull/32816#discussion_r695392832
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -297,12 +307,20 @@ case class AdaptiveSparkPlanExec(
// plans are updated, we can clear the query stage list because at
this point the two plans
// are semantically and physically in sync again.
val logicalPlan =
replaceWithQueryStagesInLogicalPlan(currentLogicalPlan, stagesToReplace)
- val (newPhysicalPlan, newLogicalPlan) = reOptimize(logicalPlan)
- val origCost = costEvaluator.evaluateCost(currentPhysicalPlan)
- val newCost = costEvaluator.evaluateCost(newPhysicalPlan)
- if (newCost < origCost ||
- (newCost == origCost && currentPhysicalPlan != newPhysicalPlan)) {
- logOnLevel(s"Plan changed from $currentPhysicalPlan to
$newPhysicalPlan")
+ val (newPhysicalPlans, newLogicalPlan) = reOptimize(logicalPlan)
+ val newPhysicalPlan =
+ (Seq(currentPhysicalPlan) ++ newPhysicalPlans)
Review comment:
I think the code can be
```
val preferredNewPhysicalPlan = ... // the plan with lowest cost and comes
first
if (newCost < oldCost || ...) ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
