Github user duncanfinney commented on a diff in the pull request:
https://github.com/apache/spark/pull/5806#discussion_r29823886
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -41,11 +44,17 @@ object SimpleAnalyzer extends Analyzer(EmptyCatalog,
EmptyFunctionRegistry, true
class Analyzer(
catalog: Catalog,
registry: FunctionRegistry,
- caseSensitive: Boolean,
+ conf: CatalystConf,
maxIterations: Int = 100)
extends RuleExecutor[LogicalPlan] with HiveTypeCoercion with
CheckAnalysis {
- val resolver = if (caseSensitive) caseSensitiveResolution else
caseInsensitiveResolution
+ def resolver: Resolver = {
--- End diff --
Don't need to change this into a function because it'll never change.
I'm more of a fan of this:
```
val resolver = caseSensitive ? caseSensitiveResolution :
caseInsensitiveResolution;
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
