viirya commented on a change in pull request #33803: URL: https://github.com/apache/spark/pull/33803#discussion_r706313462
########## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/filter/In.java ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connector.expressions.filter; + +import java.util.Arrays; +import java.util.Objects; +import java.util.stream.Collectors; + +import org.apache.spark.annotation.Evolving; +import org.apache.spark.sql.connector.expressions.Literal; +import org.apache.spark.sql.connector.expressions.NamedReference; + +/** + * A filter that evaluates to {@code true} iff the {@code column} evaluates to one of the + * {@code values} in the array. + * + * @since 3.3.0 + */ +@Evolving +public final class In extends Filter { + static final int MAX_LEN_TO_PRINT = 50; + private final NamedReference column; + private final Literal<?>[] values; + + public In(NamedReference column, Literal<?>[] values) { + this.column = column; + this.values = values; + } + + public NamedReference column() { return column; } + public Literal<?>[] values() { return values; } + + @Override + public boolean equals(Object o) { + if (this == o) return true; + if (o == null || getClass() != o.getClass()) return false; + In in = (In) o; + return Objects.equals(column, in.column) && Arrays.equals(values, in.values); + } + + @Override + public int hashCode() { + int result = Objects.hash(column); + result = 31 * result + Arrays.hashCode(values); + return result; + } + + @Override + public String toString() { + String res = Arrays.stream(values).limit((MAX_LEN_TO_PRINT)).map(Literal::describe) + .collect(Collectors.joining(", ")); + if(values.length > MAX_LEN_TO_PRINT) { Review comment: nit: style issue. Add space after `if`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
