ueshin commented on a change in pull request #33968: URL: https://github.com/apache/spark/pull/33968#discussion_r707770623
########## File path: python/pyspark/pandas/series.py ########## @@ -4548,22 +4548,31 @@ def update(self, other: "Series") -> None: if not isinstance(other, Series): raise TypeError("'other' must be a Series") - combined = combine_frames(self._psdf, other._psdf, how="leftouter") + if same_anchor(self, other): + scol = F.when(other.spark.column.isNotNull(), other.spark.column).otherwise( + self.spark.column + ) Review comment: We should alias the `scol` with the original name? `scol = ... .alias(self._psdf._internal.spark_column_name_for(self._column_label))` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org