viirya commented on a change in pull request #33930:
URL: https://github.com/apache/spark/pull/33930#discussion_r707829006
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BooleanSimplificationSuite.scala
##########
@@ -330,4 +330,118 @@ class BooleanSimplificationSuite extends PlanTest with
ExpressionEvalHelper with
checkEvaluation(originalExpr, optimizedVal, inputRow)
}
}
+
+ test("SPARK-36665: Add more Not operator simplifications") {
+ // Using IsNull(e(inputs)) == IsNull(input1) or IsNull(input2) ... rules
+ checkCondition(IsNull(Not('e)), IsNull('e))
+ checkCondition(IsNotNull(Not('e)), IsNotNull('e))
+
Review comment:
This test doesn't show the `Or` generated. Could you add another test
there are more than one child expression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
