HyukjinKwon commented on a change in pull request #34051:
URL: https://github.com/apache/spark/pull/34051#discussion_r714442193
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala
##########
@@ -104,17 +104,18 @@ case class ScalarSubquery(
}
/**
- * The physical node of in-subquery. This is for Dynamic Partition Pruning
only, as in-subquery
- * coming from the original query will always be converted to joins.
+ * The physical node of in-subquery. When this is used for Dynamic Partition
Pruning, as the pruning
+ * happens at the driver side, we don't broadcast subquery result.
*/
case class InSubqueryExec(
child: Expression,
plan: BaseSubqueryExec,
exprId: ExprId,
- private var resultBroadcast: Broadcast[Array[Any]] = null)
+ needBroadcast: Boolean = false,
+ private var resultBroadcast: Broadcast[Array[Any]] = null,
+ @transient private var result: Array[Any] = null)
Review comment:
qq: why should we move this to constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
