Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5876#discussion_r29896241
  
    --- Diff: 
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLEnv.scala
 ---
    @@ -51,6 +52,12 @@ private[hive] object SparkSQLEnv extends Logging {
           sparkContext.addSparkListener(new StatsReportListener())
           hiveContext = new HiveContext(sparkContext)
     
    +      hiveContext.metadataHive.setOut(new PrintStream(System.out, true, 
"UTF-8"))
    --- End diff --
    
    nit: is UTF-8 the right thing here? It's not the default encoding on all 
platforms. Maybe omit that argument (which probably means using the platform 
default, even though the javadocs don't explicitly mention that)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to