Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/5989#issuecomment-100116112
@rekhajoshm , Thank you. As discussed in the JIRA issue, we can keep these
names as is. But we can improve the implementation of showDF() to print c-style
strings.
str <- callJMethod(x@sdf, "showString", numToInt(numRows))
cat(str)
Also you need to update the test case for showDF() accordingly.
capture.output() can be used to capture the result of showDF() for test.
Could you update the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
