Github user jacek-lewandowski commented on the pull request:
https://github.com/apache/spark/pull/5977#issuecomment-100158160
I don't agree with this - you already use such notation in a few places
(for Idea search for `\d+\sseconds` except comments and string literals shows
16 usages for production code and 71 usages for test code, search for usages of
dot-less notation of `===` method shows 4k+ usages).
Although I can see the benefits of this style guide item for the production
code, I cannot understand how it could be forbidden for test code? How would
you use "should matchers" without this notation? Scala test frameworks are
designed to use dot-less notation to improve readability and understanding of
test cases, as well as to decrease unneeded verbosity.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
