LuciferYang commented on a change in pull request #34313:
URL: https://github.com/apache/spark/pull/34313#discussion_r737118939



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -1617,6 +1617,8 @@ case class ParseUrl(children: Seq[Expression], 
failOnError: Boolean = SQLConf.ge
 case class FormatString(children: Expression*) extends Expression with 
ImplicitCastInputTypes {
 
   require(children.nonEmpty, s"$prettyName() should take at least 1 argument")
+  require(checkArgumentIndexNotZero(children(0)), "Illegal format argument 
index = 0")

Review comment:
       @cloud-fan Is there any sample? I'll fix it later
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to