cloud-fan commented on a change in pull request #34451: URL: https://github.com/apache/spark/pull/34451#discussion_r739966757
########## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala ########## @@ -284,4 +286,93 @@ private[v2] trait V2JDBCTest extends SharedSparkSession with DockerIntegrationFu testIndexUsingSQL(s"$catalogName.new_table") } } + + def supportsTableSample: Boolean = false + + test("Test TABLESAMPLE") { + if (supportsTableSample) { Review comment: I think we can do `require(supportsTableSample)`, to avoid the extra indentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org