srowen commented on a change in pull request #34308: URL: https://github.com/apache/spark/pull/34308#discussion_r741582753
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala ########## @@ -593,6 +593,16 @@ object QueryExecutionErrors { new QueryExecutionException(message, e) } + def unsupportedParquetDictionaryDecodingError( + valueType: String, + dictionary: String, Review comment: Just let it take the dictionary object here? you can avoid having callers all call .getClass().getSimpleName() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org