HyukjinKwon commented on a change in pull request #34465: URL: https://github.com/apache/spark/pull/34465#discussion_r741633327
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala ########## @@ -189,6 +189,7 @@ class JDBCOptions( val pushDownPredicate = parameters.getOrElse(JDBC_PUSHDOWN_PREDICATE, "true").toBoolean // An option to allow/disallow pushing down aggregate into JDBC data source + // This only applies to Data Source V2 JDBC val pushDownAggregate = parameters.getOrElse(JDBC_PUSHDOWN_AGGREGATE, "false").toBoolean // An option to allow/disallow pushing down LIMIT into JDBC data source Review comment: what about `pushDownLimit`? ########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala ########## @@ -189,6 +189,7 @@ class JDBCOptions( val pushDownPredicate = parameters.getOrElse(JDBC_PUSHDOWN_PREDICATE, "true").toBoolean // An option to allow/disallow pushing down aggregate into JDBC data source + // This only applies to Data Source V2 JDBC val pushDownAggregate = parameters.getOrElse(JDBC_PUSHDOWN_AGGREGATE, "false").toBoolean // An option to allow/disallow pushing down LIMIT into JDBC data source Review comment: what about `pushDownLimit`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org