gengliangwang commented on a change in pull request #34495: URL: https://github.com/apache/spark/pull/34495#discussion_r743687488
########## File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/ParquetVectorUpdaterFactory.java ########## @@ -179,6 +183,21 @@ boolean isTimestampTypeMatched(LogicalTypeAnnotation.TimeUnit unit) { ((TimestampLogicalTypeAnnotation) logicalTypeAnnotation).getUnit() == unit; } + void validateTimestampType(DataType sparkType) { + assert(logicalTypeAnnotation instanceof TimestampLogicalTypeAnnotation); + // Throw an exception if the Parquet type is TimestampLTZ and the Catalyst type is TimestampNTZ. Review comment: Here only reading TimestampLTZ as TimestampNTZ is disallowed. Suggestions are welcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org