venkata91 commented on a change in pull request #33896:
URL: https://github.com/apache/spark/pull/33896#discussion_r744015446
##########
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##########
@@ -1716,7 +1739,31 @@ private[spark] class DAGScheduler(
if (runningStages.contains(shuffleStage) &&
shuffleStage.pendingPartitions.isEmpty) {
if (!shuffleStage.shuffleDep.shuffleMergeFinalized &&
shuffleStage.shuffleDep.getMergerLocs.nonEmpty) {
- scheduleShuffleMergeFinalize(shuffleStage)
+ // Check if a finalize task has already been scheduled. This
is to prevent the
+ // following scenario: Stage A attempt 0 fails and gets
retried. Stage A attempt 1
+ // succeeded, triggering the scheduling of shuffle merge
finalization. However,
+ // tasks from Stage A attempt 0 might still be running and
sending task completion
+ // events to DAGScheduler. This check prevents multiple
attempts to schedule merge
+ // finalization get triggered due to this.
+ if (shuffleStage.shuffleDep.getFinalizeTask.isEmpty) {
+ // If total shuffle size is smaller than the threshold,
attempt to immediately
+ // schedule shuffle merge finalization and process map stage
completion.
+ val totalSize = Try(mapOutputTracker
+
.getStatistics(shuffleStage.shuffleDep).bytesByPartitionId.sum).getOrElse(0L)
Review comment:
I think we should `finalize` even for `non-deterministic stage` +
`!isAvailable` case, if not then those file handles created for merging shuffle
files won't get closed. This is because in the retry we are refreshing merger
locations. But what we can do is `finalize` the shuffle for `non-deterministic
stage` + `!isAvailable` with `registerMergeResults` set to false that way it
asynchronously finalizes with all shuffle services but we would mark the
shuffle merge finalized and won't keep DAGScheduler waiting. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
