HeartSaVioR commented on a change in pull request #34502: URL: https://github.com/apache/spark/pull/34502#discussion_r744093040
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala ########## @@ -196,6 +210,29 @@ class RocksDB( } } + private def countKeys(): Long = { Review comment: This doesn't leverage iterator() since here we don't need to deserialize the key-value from RocksDB to produce UnsafeRowPair. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org