cloud-fan commented on a change in pull request #32875:
URL: https://github.com/apache/spark/pull/32875#discussion_r746380755
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
##########
@@ -171,6 +148,27 @@ trait Partitioning {
required.requiredNumPartitions.forall(_ == numPartitions) &&
satisfies0(required)
}
+ /**
+ * Creates a shuffle spec for this partitioning and its required
distribution. The
+ * spec is used in the scenario where an operator has multiple children
(e.g., join), and is
+ * used to decide whether this child is co-partitioned with others,
therefore whether extra
+ * shuffle shall be introduced.
+ *
+ * @param defaultNumPartitions the default number of partitions to use when
creating a new
Review comment:
Why do we need this parameter? I think we need to always provide the
numPartitions when creating a new partitioning from a shuffle spec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
