HyukjinKwon commented on pull request #34555: URL: https://github.com/apache/spark/pull/34555#issuecomment-966728384
While I think it's fine to don't backport `since` is only for internal purpose, the risk is almost zero so I am not particularly against the backport. This type hint stuff are actually something boundary between Improvement and Bug. For example, with incorrect type hints, IDE would warn that the types and arguments are mismatched. With correct type hints, it won't warn anymore. Another point is that mypy checker in the downstream project won't work correctly although they typed correctly. This would have to be considered as a bug.. @zero323 maybe we should better clarify what _bug_ this PR fixes since only bug fixes are backported to other branches in standard practice, and what @dongjoon-hyun said here makes sense in the sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
