[GitHub] [spark] wangyum commented on a change in pull request #34580: [SPARK-37270][SQL] Fix push foldable into CaseWhen branches if elseValue is empty

[GitBox]

wangyum commented on a change in pull request #34580:
URL: https://github.com/apache/spark/pull/34580#discussion_r749262265



##########
File path: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyConditionalsInPredicateSuite.scala
##########
@@ -108,15 +108,18 @@ class SimplifyConditionalsInPredicateSuite extends 
PlanTest {
     Seq(Some(FalseLiteral), None, Some(Literal(null, BooleanType))).foreach { 
elseExp =>
       val originalCond = CaseWhen(
         Seq((UnresolvedAttribute("i") > Literal(10), 
UnresolvedAttribute("b"))),
-        elseExp)
+        elseExp).as("c")

Review comment:
       Add alias to avoid test failure:
   ```
   == FAIL: Plans do not match ===
   !Project [CASE WHEN (i#0 > 10) THEN b#0 END AS CASE WHEN (i > 10) THEN b 
ELSE NULL END#0]   Project [CASE WHEN (i#0 > 10) THEN b#0 END AS CASE WHEN (i > 
10) THEN b END#0]
    +- LocalRelation <empty>, [i#0, b#0, a#0, m#0]                              
               +- LocalRelation <empty>, [i#0, b#0, a#0, m#0]
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org