Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r12502522
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -125,6 +127,25 @@ object Vectors {
}
/**
+ * Parses a string resulted from `Vector#toString` into
+ * an [[org.apache.spark.mllib.linalg.Vector]].
+ */
+ def parse(s: String): Vector = {
+ parseNumeric(NumericParser.parse(s))
+ }
+
+ private[mllib] def parseNumeric(any: Any): Vector = {
+ any match {
+ case values: Array[Double] =>
+ Vectors.dense(values)
+ case Seq(size: Double, indices: Array[Double], values:
Array[Double]) =>
+ Vectors.sparse(size.toInt, indices.map(_.toInt), values)
+ case other =>
+ sys.error(s"Cannot parse $other.")
--- End diff --
You shouldn't report errors this way, it will trigger a RuntimeException,
which is not caught by default in catch blocs. Throw a new SparkException
instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
