sarutak commented on a change in pull request #34607:
URL: https://github.com/apache/spark/pull/34607#discussion_r750964537
##########
File path: core/src/main/resources/org/apache/spark/ui/static/stagepage.js
##########
@@ -652,6 +652,38 @@ $(document).ready(function () {
executorSummaryTableSelector.column(14).visible(dataToShow.showBytesSpilledData);
});
+ // Prepare data for speculation metrics
+ $("#speculationSummaryTitle").hide()
Review comment:
nit: Some statements added by this change doesn't end with `;`.
##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala
##########
@@ -747,6 +753,19 @@ private[spark] class AppStatusListener(
maybeUpdate(esummary, now)
}
+ val speculationStageSummary = stage.speculationStageSummary
+ if (event.taskInfo.speculative) {
+ speculationStageSummary.numActiveTasks -= 1
+ speculationStageSummary.numCompletedTasks += completedDelta
+ speculationStageSummary.numFailedTasks += failedDelta
+ speculationStageSummary.numKilledTasks += killedDelta
+ }
+ if (isLastTask && event.taskInfo.speculative) {
+ update(speculationStageSummary, now)
+ } else {
+ maybeUpdate(speculationStageSummary, now)
Review comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
