Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4467#discussion_r30020503
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala
 ---
    @@ -81,12 +112,14 @@ class ReceiverTracker(ssc: StreamingContext, 
skipReceiverLaunch: Boolean = false
             "ReceiverTracker", new ReceiverTrackerEndpoint(ssc.env.rpcEnv))
           if (!skipReceiverLaunch) receiverExecutor.start()
           logInfo("ReceiverTracker started")
    +      trackerState = Started
         }
       }
     
       /** Stop the receiver execution thread. */
       def stop(graceful: Boolean): Unit = synchronized {
    -    if (!receiverInputStreams.isEmpty && endpoint != null) {
    +    if (isTrackerStarted) {
    +      trackerState = Stopping
    --- End diff --
    
    We need to prevent the receiver to step forward if the tracker is entering 
stopping status. So we don't have the risk to lose data. Without 
`ReceiverStarted`, we may have to modify the current receiver initialization.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to