sadikovi commented on a change in pull request #34596:
URL: https://github.com/apache/spark/pull/34596#discussion_r752883351
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TimestampFormatter.scala
##########
@@ -121,6 +122,10 @@ class Iso8601TimestampFormatter(
override def parseWithoutTimeZone(s: String): Long = {
Review comment:
It is used to parse any timestamp without timezone, used in timestamp
functions and CSV and JSON data sources.
I am a bit confused now. That is why I introduced a separate method
isTimeZoneSet to not modify the behaviour of the original method since it did
not throw an exception.
I think the current changes should be fine, I updated all of the necessary
tests. The behaviour has changed - now if you try to run `parseWithoutTimeZone`
on a timestamp with timezone, it will throw an exception.
How can one evaluate other behaviour changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
