kazuyukitanimura commented on a change in pull request #34611:
URL: https://github.com/apache/spark/pull/34611#discussion_r751886931
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedPlainValuesReader.java
##########
@@ -53,20 +53,45 @@ public void skip() {
throw new UnsupportedOperationException();
}
+ private void updateCurrentByte() {
+ try {
+ currentByte = in.read();
+ } catch (IOException e) {
+ throw new ParquetDecodingException("Failed to read a byte", e);
+ }
+ }
+
@Override
public final void readBooleans(int total, WritableColumnVector c, int rowId)
{
- // TODO: properly vectorize this
- for (int i = 0; i < total; i++) {
- c.putBoolean(rowId + i, readBoolean());
+ int i = 0;
+ if (bitOffset > 0) {
+ i = Math.min(8 - bitOffset, total);
+ c.putBooleans(rowId, i, currentByte, bitOffset);
+ bitOffset = (bitOffset + i) & 7;
+ }
+ for (; i + 7 < total; i += 8) {
+ updateCurrentByte();
+ c.putBooleans(rowId + i, currentByte);
+ }
+ if (i < total) {
+ updateCurrentByte();
+ bitOffset = total - i;
+ c.putBooleans(rowId + i, bitOffset, currentByte, 0);
}
}
@Override
public final void skipBooleans(int total) {
- // TODO: properly vectorize this
- for (int i = 0; i < total; i++) {
- readBoolean();
+ int totalByte = total / 8;
+ if (totalByte > 0) {
+ try {
+ in.skipFully(totalByte - 1L);
Review comment:
Right, the first line should have been
```
int skipBytes = (bitOffset + total) / 8 - 1;
```
E.g.
`skip 9 values`; for this example, given `bitOffset = 0`, executing
`skipBooleans(total = 9)` will be
```
int skipBytes = (bitOffset + total) / 8 - 1; // = (0+9)/8-1 = 0
bitOffset = (bitOffset + total) & 7; // = (0+9)&7 = 1
if (skipBytes >= 0) {
...
in.skipFully(skipBytes); // in.skipFully(0)
if (bitOffset > 0) {
currentByte = in.read(); // making currentByte ready
}
```
`read 7 values and ... skip 11?`; for this example, given `bitOffset = 7`
executing `skipBooleans(total = 11)` will be
```
int skipBytes = (bitOffset + total) / 8 - 1; // = (7+11)/8-1 = 1
bitOffset = (bitOffset + total) & 7; // = (7+11)&7 = 2
if (skipBytes >= 0) {
...
in.skipFully(skipBytes); // in.skipFully(1)
if (bitOffset > 0) {
currentByte = in.read(); // making currentByte ready
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
