[GitHub] [spark] cloud-fan commented on a change in pull request #34644: [SPARK-36357][SQL] Support pushdown Timestamp without time zone for orc

[GitBox]

cloud-fan commented on a change in pull request #34644:
URL: https://github.com/apache/spark/pull/34644#discussion_r752910817



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilters.scala
##########
@@ -168,6 +168,8 @@ private[sql] object OrcFilters extends OrcFiltersBase {
       toJavaDate(localDateToDays(value.asInstanceOf[LocalDate]))
     case _: TimestampType if value.isInstanceOf[Instant] =>
       toJavaTimestamp(instantToMicros(value.asInstanceOf[Instant]))
+    case _: TimestampNTZType =>

Review comment:
       ```suggestion
       case _: TimestampNTZType if value.isInstanceOf[LocalDateTime] =>
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org