cloud-fan commented on a change in pull request #34575:
URL: https://github.com/apache/spark/pull/34575#discussion_r752946851
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala
##########
@@ -171,6 +171,27 @@ trait FileFormat {
def supportFieldName(name: String): Boolean = true
}
+object FileFormat {
+
+ val FILE_PATH = "file_path"
+
+ val FILE_NAME = "file_name"
+
+ val FILE_SIZE = "file_size"
+
+ val FILE_MODIFICATION_TIME = "file_modification_time"
+
+ val METADATA_NAME = "_metadata"
+
+ // supported metadata columns for hadoop fs relation
+ val FILE_METADATA_COLUMNS: AttributeReference =
MetadataAttribute(METADATA_NAME,
Review comment:
I think this should be a `def`, otherwise all the file source metadata
columns share one `ExprId`. This can cause issues if you scan two file sources
and join them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
