advancedxy commented on pull request #34623:
URL: https://github.com/apache/spark/pull/34623#issuecomment-973876125


   > > Also, is it possible for you to add a unit test for this case.
   > > When we set spark.sql.thriftServer.queryTimeout to 10800s, and STS 
running for a long time and finish some query submiited  by jdbc.We dump the 
driver heap and find there are too many thread named 'pool-*-thread-1' and 
dirver heap is full.
   > > When we set spark.sql.thriftServer.queryTimeout to 0s,the above 
phenomenon did not occur again.
   > > 
![image](https://user-images.githubusercontent.com/39769581/142173193-944a29fa-e6c8-4e7f-ac01-ff655bdf58b1.png)
   > 
   > So the problem is that the timeoutExecutor doesn't shutdown timely? The 
thread will be living at least `timeout` duration even the statement has 
already finished. This will be a problem for a heavy sts.
   
   A unit test should possible to check the number of timeout threads for 
normal queries.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to