zero323 commented on a change in pull request #34466:
URL: https://github.com/apache/spark/pull/34466#discussion_r753819793
##########
File path: python/pyspark/context.py
##########
@@ -180,20 +205,20 @@ def __init__(
def _do_init(
self,
- master,
- appName,
- sparkHome,
- pyFiles,
- environment,
- batchSize,
- serializer,
- conf,
- jsc,
- profiler_cls,
- ):
+ master: Optional[str],
+ appName: Optional[str],
+ sparkHome: Optional[str],
+ pyFiles: Optional[List[str]],
+ environment: Optional[Dict[str, str]],
+ batchSize: int,
+ serializer: Serializer,
+ conf: Optional[SparkConf],
+ jsc: JavaObject,
+ profiler_cls: type,
+ ) -> Any:
Review comment:
`_do_init` is used only for side effects and returns nothing, so should
be `-> None`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
