cloud-fan commented on a change in pull request #34683:
URL: https://github.com/apache/spark/pull/34683#discussion_r754397467
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala
##########
@@ -1411,6 +1411,7 @@ object HiveExternalCatalog {
private[spark] def isHiveCompatibleDataType(dt: DataType): Boolean = dt
match {
case _: AnsiIntervalType => false
+ case _: TimestampNTZType => false
Review comment:
We need to make a decision here. Storing both ltz and ntz as hive
timestamp is also an option. In fact, the hive timestamp is ntz, so storing ntz
as hive timestamp is actually correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
