cloud-fan commented on a change in pull request #34668:
URL: https://github.com/apache/spark/pull/34668#discussion_r755142758
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -73,6 +78,19 @@ grammar SqlBase;
return false;
}
}
+
+ /**
+ * This method will be called when the character stream ends and try to find
out the
+ * unclosed bracketed comment.
+ * If the next character is -1, it means the end of the entire character
stream match,
Review comment:
BTW do we need to check? looking at `('*/' | {end();} EOF)`, seems it's
always EOF if we enter this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
