pan3793 commented on a change in pull request #34692:
URL: https://github.com/apache/spark/pull/34692#discussion_r755634427
##########
File path: core/src/main/scala/org/apache/spark/util/SizeEstimator.scala
##########
@@ -33,10 +33,9 @@ import org.apache.spark.util.collection.OpenHashSet
/**
* A trait that allows a class to give [[SizeEstimator]] more accurate size
estimation.
- * When a class extends it, [[SizeEstimator]] will query the `estimatedSize`
first.
- * If `estimatedSize` does not return `None`, [[SizeEstimator]] will use the
returned size
- * as the size of the object. Otherwise, [[SizeEstimator]] will do the
estimation work.
- * The difference between a [[KnownSizeEstimation]] and
+ * When a class extends it, [[SizeEstimator]] will query the `estimatedSize`,
and use
+ * the returned size as the size of the object. Otherwise, [[SizeEstimator]]
will do
Review comment:
#9813 change the method return type from `Option[Long]` to `Long`, but
not update the comment.
"If `estimatedSize` does not return `None`" should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
