sarutak commented on a change in pull request #34593:
URL: https://github.com/apache/spark/pull/34593#discussion_r755696389
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala
##########
@@ -413,6 +413,18 @@ final class Decimal extends Ordered[Decimal] with
Serializable {
if (doubled > pow10diff || doubled == pow10diff && longVal % 2 !=
0) {
longVal += (if (droppedDigits < 0) -1L else 1L)
}
+ case ROUND_UP =>
Review comment:
> Out of curiosity, may i know why it will be a bug if changePrecision
takes ROUND_UP, ROUND_DOWN or ROUND_HALF_DOWN ?
It's not expected that `ROUND_UP`, `ROUND_DOWN` and `ROUND_HALF_DOWN` are
not expected to be passed to `changePrecision` and it's private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
