peter-toth commented on a change in pull request #34693:
URL: https://github.com/apache/spark/pull/34693#discussion_r755830269
##########
File path:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/MsSqlServerIntegrationSuite.scala
##########
@@ -356,4 +357,42 @@ class MsSqlServerIntegrationSuite extends
DockerJDBCIntegrationSuite {
0, 3, 0, 0, 0, -1, -1, -1, -1, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0,
2, 0,
0, 0, 0, 1, 0, 0, 0, 3))
}
+
+ test("withClause and query JDBC options") {
+ val expectedResult = Set(
+ (42, "fred"),
+ (17, "dave")
+ ).map { case (x, y) =>
+ Row(Integer.valueOf(x), String.valueOf(y))
+ }
+
+ val withClause = "WITH t AS (SELECT x, y FROM tbl)"
+ val query = "SELECT * FROM t WHERE x > 10"
+ val df = spark.read.format("jdbc")
+ .option("url", jdbcUrl)
+ .option("withClause", withClause)
+ .option("query", query)
+ .load()
+ assert(df.collect.toSet === expectedResult)
+
+ df.explain(true)
+ }
+
+ test("withClause and dbtable JDBC options") {
+ val expectedResult = Set(
+ (42, "fred"),
+ (17, "dave")
+ ).map { case (x, y) =>
+ Row(Integer.valueOf(x), String.valueOf(y))
+ }
+
+ val withClause = "WITH t AS (SELECT x, y FROM tbl WHERE x > 10)"
+ val dbtable = "t"
+ val df = spark.read.format("jdbc")
+ .option("url", jdbcUrl)
+ .option("withClause", withClause)
+ .option("dbtable", dbtable)
+ .load()
+ assert(df.collect.toSet === expectedResult)
+ }
Review comment:
Ok. Added in
https://github.com/apache/spark/commit/dea730a12503328b98375cf4d4590444db31d090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
