zero323 commented on a change in pull request #34513:
URL: https://github.com/apache/spark/pull/34513#discussion_r756794845
##########
File path: python/pyspark/mllib/stat/_statistics.py
##########
@@ -168,12 +190,34 @@ def corr(x, y=None, method=None):
raise TypeError("Use 'method=' to specify method name.")
if not y:
- return callMLlibFunc("corr", x.map(_convert_to_vector),
method).toArray()
+ return cast(
+ JavaObject, callMLlibFunc("corr", x.map(_convert_to_vector),
method)
+ ).toArray()
else:
- return callMLlibFunc("corr", x.map(float), y.map(float), method)
+ return cast(
+ Union[float, Matrix],
Review comment:
@nchammas Just looking at this, we might have to make adjust signatures
for `callMLlibFunc` and `callMLlibFunc` which match `_java2py` but don't take
into account types that are automatically converted to Python types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
