cloud-fan commented on a change in pull request #34060:
URL: https://github.com/apache/spark/pull/34060#discussion_r756898767
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala
##########
@@ -481,19 +481,26 @@ class PlanResolutionSuite extends AnalysisTest {
"other" -> "20")
parseAndResolve(sql) match {
- case create: CreateV2Table =>
- assert(create.catalog.name == "testcat")
- assert(create.tableName == Identifier.of(Array("mydb"), "table_name"))
+ case create: CatalystCreateTable =>
+ assert(create.name.asInstanceOf[ResolvedDBObjectName].catalog.name ==
"testcat")
+
assert(create.name.asInstanceOf[ResolvedDBObjectName].nameParts.mkString(".") ==
+ "mydb.table_name")
assert(create.tableSchema == new StructType()
.add("id", LongType)
.add("description", StringType)
.add("point", new StructType().add("x", DoubleType).add("y",
DoubleType)))
assert(create.partitioning.isEmpty)
- assert(create.properties == expectedProperties)
Review comment:
do we have end-to-end test for CREATE TABLE? we can test it there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
