Yikun commented on pull request #34646:
URL: https://github.com/apache/spark/pull/34646#issuecomment-981371597


   @dongjoon-hyun Would you mind taking a look again? Or I misundertanded your 
suggestion, it's not enough to update the PR message, I should split this PR to 
2 PRs:
   1. Remove the redundant edition, then passed new added the ut 
"assert(executor.pod.getMetadata.getLabels === conf.labels.asJava)", and 
[existing conf.label 
ut](https://github.com/apache/spark/blob/a3886ba976469bef0dfafc3da8686a53c5a59d95/resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesConfSuite.scala#L157).
   2. then refactor CUSTOM_DRIVER_LABELS logic?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to