cloud-fan commented on a change in pull request #34684:
URL: https://github.com/apache/spark/pull/34684#discussion_r758931580



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala
##########
@@ -237,7 +238,23 @@ case class CachedRDDBuilder(
   }
 
   def isCachedColumnBuffersLoaded: Boolean = {
-    _cachedColumnBuffers != null
+    _cachedColumnBuffers != null && isCachedRDDLoaded
+  }
+
+  def isCachedRDDLoaded: Boolean = {

Review comment:
       I'm not sure if it's necessary or not, but it's not difficult to apply 
double lock here and make this method thread-safe.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to