sadikovi commented on a change in pull request #34596:
URL: https://github.com/apache/spark/pull/34596#discussion_r759000008
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVInferSchema.scala
##########
@@ -160,6 +169,17 @@ class CSVInferSchema(val options: CSVOptions) extends
Serializable {
private def tryParseDouble(field: String): DataType = {
if ((allCatch opt field.toDouble).isDefined || isInfOrNan(field)) {
DoubleType
+ } else {
+ tryParseTimestampNTZ(field)
+ }
+ }
+
+ private def tryParseTimestampNTZ(field: String): DataType = {
+ // We can only parse the value as TimestampNTZType if it does not have
zone-offset or
+ // time-zone component and can be parsed with the timestamp formatter.
+ // Otherwise, it is likely to be a timestamp with timezone.
+ if ((allCatch opt timestampNTZFormatter.parseWithoutTimeZone(field,
true)).isDefined) {
Review comment:
Could you elaborate a bit more? Thanks.
My understanding was that the config indicated whether the output of parsing
should be treated as TimestampNTZ or TimestampLTZ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
