cloud-fan commented on a change in pull request #32875: URL: https://github.com/apache/spark/pull/32875#discussion_r761766386
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala ########## @@ -70,61 +70,98 @@ case class EnsureRequirements( val childrenIndexes = requiredChildDistributions.zipWithIndex.filter { case (UnspecifiedDistribution, _) => false case (_: BroadcastDistribution, _) => false + case (AllTuples, _) => false Review comment: shall we also exclude `OrderedDistribution`? It does not have a real impact as in Spark there is no operator requires multiple `OrderedDistribution` today, but it makes the code cleaner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org