cloud-fan commented on a change in pull request #34575: URL: https://github.com/apache/spark/pull/34575#discussion_r772861339
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/SchemaPruning.scala ########## @@ -164,7 +164,12 @@ object SchemaPruning extends Rule[LogicalPlan] { outputRelation: LogicalRelation, prunedBaseRelation: HadoopFsRelation) = { val prunedOutput = getPrunedOutput(outputRelation.output, prunedBaseRelation.schema) - outputRelation.copy(relation = prunedBaseRelation, output = prunedOutput) + // also add the metadata output if any + // TODO: should be able to prune the metadata schema Review comment: makes sense. Let's update this rule or add a new rule `MetadataSchemaPruning` later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org