Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/5786#issuecomment-101459672
> We all understand that POMs define how assemblies are built. This can't
have nothing to do with them.
You're mixing "published POMs" with the actual pom files in the build. They
are not the same thing and that's what's making me incredibly confused.
> You're suggesting reverting to restore the default to work with Hadoop
1.x
No, I'm suggesting fixing it, one way or another, which one doesn't matter.
> but then that trips a different version-related problem: the published
POM for Spark 1.3 already references Hadoop 2.2.0.
That's completely unrelated; the build that actually does a "mvn deploy" to
update the maven artifacts needs to match the profiles needed to replicate the
1.3 build. That's completely separate from what the default property values
are, which is what this PR is about.
To summarize: fixing what the "default build" should be, or whether we
should have a "default build" at all, is irrelevant to the published poms, and
bringing them up just causes confusion.
This PR exists for a simple reason: the artifacts generated when you build
with the current default properties are broken. Period.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
