Peng-Lei commented on a change in pull request #34719: URL: https://github.com/apache/spark/pull/34719#discussion_r778891936
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowCreateTableSuite.scala ########## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.command.v1 + +import org.apache.spark.sql.execution.command + +/** + * This base suite contains unified tests for the `SHOW CREATE TABLE` command that checks V1 + * table catalogs. The tests that cannot run for all V1 catalogs are located in more + * specific test suites: + * + * - V1 In-Memory catalog: `org.apache.spark.sql.execution.command.v1.ShowCreateTableSuite` + * - V1 Hive External catalog: + * `org.apache.spark.sql.hive.execution.command.ShowCreateTableSuite` + */ +trait ShowCreateTableSuiteBase extends command.ShowCreateTableSuiteBase + with command.TestsV1AndV2Commands { + override def fullName: String = s"`$ns`.`$table`" + test("CTAS") { + withNamespaceAndTable(ns, table) { t => + sql( + s"""CREATE TABLE $t + |USING json + |PARTITIONED BY (c) + |CLUSTERED BY (a) SORTED BY (b) INTO 2 BUCKETS + |COMMENT 'This is a comment' + |TBLPROPERTIES ('a' = '1') + |AS SELECT 1 AS a, "foo" AS b, 2.5 AS c + """.stripMargin + ) + val showDDL = getShowCreateDDL(s"SHOW CREATE TABLE $t") + assert(showDDL(0) == s"CREATE TABLE $fullName (") + assert(showDDL(1) == "`a` INT,") + assert(showDDL(2) == "`b` STRING,") + assert(showDDL(3) == "`c` DECIMAL(2,1))") + assert(showDDL(4) == s"USING json") + assert(showDDL(5) == "PARTITIONED BY (c)") + assert(showDDL(6) == "CLUSTERED BY (a)") + assert(showDDL(7) == s"SORTED BY (b)") + assert(showDDL(8) == s"INTO 2 BUCKETS") + assert(showDDL(9) == "COMMENT 'This is a comment'") + assert(showDDL(10) == "TBLPROPERTIES (") + assert(showDDL(11) == s"'a' = '1')") + } + } +} + +/** + * The class contains tests for the `SHOW CREATE TABLE` command to check V1 In-Memory + * table catalog. + */ +class ShowCreateTableSuite extends ShowCreateTableSuiteBase with CommandSuiteBase { + override def commandVersion: String = super[ShowCreateTableSuiteBase].commandVersion + // todo After SPARK-37517 unify the testcase both v1 and v2 + test("show create table") { Review comment: two diffs between v1 and hive: 1. default using does not match. The defaultUsing == "USING HIVE" when test for hive catalog, but the result is `USING TEXT` of `show create table`. because hive is not datasource table, so we call `convertTableMetadata` for `SHOW CREATE TABLE`. Then `HiveSerDe.serdeToSource` to get the source as the provider of output. 2. more properties(transient_lastDdlTime) for hive. The code is [#L1100](https://github.com/apache/spark/blob/b9b5562f6b458c59a706fd6ab0d5b2813d0bdb96/sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala#L1100) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
