cloud-fan commented on a change in pull request #34729:
URL: https://github.com/apache/spark/pull/34729#discussion_r779579258
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala
##########
@@ -357,18 +367,18 @@ class MathExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
}
test("floor") {
- testUnary(Floor, (d: Double) => math.floor(d).toLong)
+ testUnary(Floor.apply, (d: Double) => math.floor(d).toLong)
Review comment:
unnecessary change?
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala
##########
@@ -357,18 +367,18 @@ class MathExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
}
test("floor") {
- testUnary(Floor, (d: Double) => math.floor(d).toLong)
+ testUnary(Floor.apply, (d: Double) => math.floor(d).toLong)
checkConsistencyBetweenInterpretedAndCodegen(Floor, DoubleType)
- testUnary(Floor, (d: Decimal) => d.floor, (-20 to 20).map(x => Decimal(x *
0.1)))
+ testUnary(Floor.apply, (d: Decimal) => d.floor, (-20 to 20).map(x =>
Decimal(x * 0.1)))
Review comment:
ditto
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala
##########
@@ -357,18 +367,18 @@ class MathExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
}
test("floor") {
- testUnary(Floor, (d: Double) => math.floor(d).toLong)
+ testUnary(Floor.apply, (d: Double) => math.floor(d).toLong)
checkConsistencyBetweenInterpretedAndCodegen(Floor, DoubleType)
- testUnary(Floor, (d: Decimal) => d.floor, (-20 to 20).map(x => Decimal(x *
0.1)))
+ testUnary(Floor.apply, (d: Decimal) => d.floor, (-20 to 20).map(x =>
Decimal(x * 0.1)))
checkConsistencyBetweenInterpretedAndCodegen(Floor, DecimalType(25, 3))
checkConsistencyBetweenInterpretedAndCodegen(Floor, DecimalType(25, 0))
checkConsistencyBetweenInterpretedAndCodegen(Floor, DecimalType(5, 0))
val doublePi: Double = 3.1415
val floatPi: Float = 3.1415f
val longLit: Long = 12345678901234567L
- val nullLit = Literal.create(null, NullType)
+ val nullLit = Literal.create(null, NullType)
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
