zero323 commented on pull request #34354: URL: https://github.com/apache/spark/pull/34354#issuecomment-1008188701
> t seems to be the best for now, until mypy itself supports looser typing conventions. As @ueshin pointed out, using `Sequence` might provide more general approach (and allow us to forget about variance), but there are two problems: - It is high level interface that potentially covers more than lists and tuples. So this would require change of the logic, and to provide consistent UX, we should probably to the same in other places where sequence-ish input is accepted. - There is concern of ambiguity (`str` is a `Sequence[str]`), which causes my irrational feat that it can break in some hard to contain ways (most likely, I am overthinking it). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
