cloud-fan commented on a change in pull request #35132: URL: https://github.com/apache/spark/pull/35132#discussion_r780998540
########## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala ########## @@ -299,11 +292,26 @@ private[orc] class OrcOutputWriter( } override def close(): Unit = { - if (recordWriterInstantiated) { + try { + OrcUtils.addSparkVersionMetadata(getOrCreateInternalWriter()) + } catch { + case NonFatal(e) => log.warn(e.toString, e) + } + recordWriter.close(Reporter.NULL) + } + + private def getOrCreateInternalWriter(): Writer = { + val writerField = recordWriter.getClass.getDeclaredField("writer") + writerField.setAccessible(true) + var writer = writerField.get(recordWriter).asInstanceOf[Writer] + if (writer == null) { Review comment: do we need to consider multi-thread here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org