cloud-fan commented on a change in pull request #34729:
URL: https://github.com/apache/spark/pull/34729#discussion_r783141517
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala
##########
@@ -705,6 +818,42 @@ class MathExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
checkEvaluation(BRound(-3.5, 0), -4.0)
checkEvaluation(BRound(-0.35, 1), -0.4)
checkEvaluation(BRound(-35, -1), -40)
+ checkEvaluation(checkDataTypeAndCast(
+ FloorExpressionBuilder.build(Seq(Literal(2.5), Literal(0)))), 2L)
+ checkEvaluation(checkDataTypeAndCast(
+ FloorExpressionBuilder.build(Seq(Literal(3.5), Literal(0)))), 3L)
+ checkEvaluation(checkDataTypeAndCast(
+ FloorExpressionBuilder.build(Seq(Literal(-2.5), Literal(0)))), -3L)
+ checkEvaluation(checkDataTypeAndCast(
+ FloorExpressionBuilder.build(Seq(Literal(-3.5), Literal(0)))), -4L)
+ checkEvaluation(checkDataTypeAndCast(
+ FloorExpressionBuilder.build(Seq(Literal(-0.35), Literal(1)))), -0.4)
+ checkEvaluation(checkDataTypeAndCast(
+ FloorExpressionBuilder.build(Seq(Literal(-35), Literal(-1)))), -40L)
+ checkEvaluation(checkDataTypeAndCast(
+ CeilExpressionBuilder.build(Seq(Literal(2.5), Literal(0)))), 3L)
+ checkEvaluation(checkDataTypeAndCast(
+ CeilExpressionBuilder.build(Seq(Literal(3.5), Literal(0)))), 4L)
+ checkEvaluation(checkDataTypeAndCast(
+ CeilExpressionBuilder.build(Seq(Literal(-2.5), Literal(0)))), -2L)
+ checkEvaluation(checkDataTypeAndCast(
+ CeilExpressionBuilder.build(Seq(Literal(-3.5), Literal(0)))), -3L)
+ checkEvaluation(checkDataTypeAndCast(
+ CeilExpressionBuilder.build(Seq(Literal(-0.35), Literal(1)))), -0.3)
+ checkEvaluation(checkDataTypeAndCast(
+ CeilExpressionBuilder.build(Seq(Literal(-35), Literal(-1)))), -30L)
+ checkEvaluation(checkDataTypeAndCast(
+ FloorExpressionBuilder.build(Seq(Literal(-0.1), Literal(0)))), -1L)
+ checkEvaluation(checkDataTypeAndCast(
+ FloorExpressionBuilder.build(Seq(Literal(5), Literal(0)))), 5L)
+ checkEvaluation(checkDataTypeAndCast(
+ FloorExpressionBuilder.build(Seq(Literal(3.1411), Literal(-3)))), 0L)
+ checkEvaluation(checkDataTypeAndCast(
+ CeilExpressionBuilder.build(Seq(Literal(-0.1), Literal(0)))), 0L)
+ checkEvaluation(checkDataTypeAndCast(
+ CeilExpressionBuilder.build(Seq(Literal(5), Literal(0)))), 5L)
+ checkEvaluation(checkDataTypeAndCast(
+ CeilExpressionBuilder.build(Seq(Literal(3.1411), Literal(-3)))), 1000L)
Review comment:
`RoundFloor` has a similar issue, if the input is a negative value.
My proposal is, for `round/ceil(input, scale)` if `scale != 0`, the expected
input type should be decimal type, and the type coercion framework should cast
int, double, etc. to decimal type. The result type can be
```
case DecimalType.Fixed(p, s) =>
if (scale < 0) {
DecimalType(math.max(p, 1 - scala), 0)
} else {
DecimalType(p, math.min(s, scale))
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
