Github user sryza commented on a diff in the pull request: https://github.com/apache/spark/pull/5449#discussion_r30286942 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -119,7 +130,27 @@ private[yarn] class YarnAllocator( def getNumExecutorsRunning: Int = numExecutorsRunning - def getNumExecutorsFailed: Int = numExecutorsFailed + def getNumExecutorsFailed: Int = { + if (relativeMaxExecutorFailureEnabled) { + getRelevantNumExecutorsFailed + } else { + numExecutorsFailed.intValue + } + } + + /** + * Returns the the relative number of executor failures within the specified window duration. + */ + + def getRelevantNumExecutorsFailed : Int = { + val currentTime = System.currentTimeMillis / 1000 + val relevantWindowStartTime = currentTime - 60 + while(relevantWindowStartTime > oldestRelativeExecutorFailure && --- End diff -- Need spaces before and after these parentheses.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org