wangyum commented on code in PR #36080: URL: https://github.com/apache/spark/pull/36080#discussion_r843428746
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala: ########## @@ -132,28 +131,21 @@ object InjectRuntimeFilter extends Rule[LogicalPlan] with PredicateHelper with J REGEXP_EXTRACT_FAMILY, REGEXP_REPLACE) } - private def canFilterLeft(joinType: JoinType): Boolean = joinType match { - case Inner | RightOuter => true - case _ => false - } - - private def canFilterRight(joinType: JoinType): Boolean = joinType match { - case Inner | LeftOuter => true - case _ => false - } Review Comment: Move these functions to `JoinSelectionHelper` to make the code easier to maintain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org