dtenedor commented on code in PR #36066: URL: https://github.com/apache/spark/pull/36066#discussion_r844214435
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/numberFormatExpressions.scala: ########## @@ -98,8 +105,82 @@ case class ToNumber(left: Expression, right: Expression) |} """.stripMargin) } - override protected def withNewChildrenInternal( - newLeft: Expression, newRight: Expression): ToNumber = copy(left = newLeft, right = newRight) + newLeft: Expression, newRight: Expression): ToNumber = + copy(left = newLeft, right = newRight) } +/** + * A function that converts strings to decimal values, returning NULL if the input string fails to + * match the format string. + */ +@ExpressionDescription( + usage = """ + _FUNC_(expr, fmt) - Convert string 'expr' to a number based on the string format `fmt`. + Returns NULL if the string 'expr' does not match the expected format. The format can consist Review Comment: SG, done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org