cloud-fan commented on code in PR #36069:
URL: https://github.com/apache/spark/pull/36069#discussion_r845740358
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FilePartitionReaderFactory.scala:
##########
@@ -16,20 +16,21 @@
*/
package org.apache.spark.sql.execution.datasources.v2
-import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.{FileSourceOptions, InternalRow}
import org.apache.spark.sql.connector.read.{InputPartition, PartitionReader,
PartitionReaderFactory}
import org.apache.spark.sql.errors.QueryExecutionErrors
import org.apache.spark.sql.execution.datasources.{FilePartition,
PartitionedFile}
import org.apache.spark.sql.vectorized.ColumnarBatch
-abstract class FilePartitionReaderFactory extends PartitionReaderFactory {
+abstract class FilePartitionReaderFactory(options: FileSourceOptions)
Review Comment:
then we don't need to change its subclasses, as they are case class and
already implicitly provided the `options` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
